don't show in progress items in build queue #2622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
dont-show-in-progress-in-queue
branch
2 times, most recently
from
cd40e6b to
eba0010
Compare
GuillaumeGomez
approved these changes
Oct 20, 2024
syphar
force-pushed
the
dont-show-in-progress-in-queue
branch
from
eba0010 to
0fd7a4d
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the build queue currently works so a crate is still shown in the queue even when it's currently being built. Only after the build finished, we remove it from there. Generally I want to keep this design because combined with transactions it safeguards against any errors leading to a release being removed from the queue without being handled.
But looking at our build-queue page, I currently see every in-progress build twice, once in the queue and once in the new section for in-progress builds. This we don't need.